Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed solc version to 0.8.26 - resolves #5427 #5428

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

aaronzshey
Copy link
Contributor

  • [ x ] Because this PR includes a bug fix, relevant tests have been included.

in hardhat/packages/hardhat-core/src/internal/solidity/compiler/solcrunner.js, the previously offending package solc is used. this is solc's only appearance in this ENTIRE project. By bumping the solc version from 0.7.3 to 0.8.26, rimraf is no longer a dependency, and one instance of an outdated glob being used has also been removed.

resolves #5427

Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: e00b69f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 2:43pm

@alcuadrado
Copy link
Member

Thanks @aaronzshey.

We used to have a different way to handle solcjs that forced us to keep this version, but that went away, so this change is now safe.

@aaronzshey
Copy link
Contributor Author

You bet! Closes #5427

@alcuadrado alcuadrado merged commit a0c1d90 into NomicFoundation:main Jun 25, 2024
85 of 86 checks passed
Copy link

gitpoap-bot bot commented Jun 25, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Hardhat Contributor:

GitPOAP: 2024 Hardhat Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

solc version outdated
3 participants